Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Name, Block Number, Moved to Last Call #2408

Merged
merged 11 commits into from
Dec 1, 2019
Merged

Conversation

MadeofTin
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-automerger
Copy link

eip-automerger commented Nov 29, 2019

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • Trying to change EIP 2384 state from Draft to Last Call
  • Trying to change EIP 2387 state from Draft to Last Call
  • EIP 2384 requires approval from one of (@econoar)

author: James Hancock (@madeoftin)
discussions-to: https://ethereum-magicians.org/t/hard-fork-to-address-the-ice-age-eip-2387
type: Meta
status: Draft
status: Last Call
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add review-period-ends: 12-12-2019 (13th would be two weeks, but that's just Friday 13th 😉)

@axic
Copy link
Member

axic commented Nov 29, 2019

Can you also set EIP-2834 to last call with the same review date in this PR? I'll merge it.

@axic axic merged commit 42c4294 into ethereum:master Dec 1, 2019
@axic
Copy link
Member

axic commented Dec 1, 2019

Ah, also should have updated the title of 2384.

tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
* Updated Name and Block Number

* Updated Ropsten Fork Number

* Updated POA Testnets

* Muir Glacier: Updated lastcall review date and POA Language.

* Difficult Bomb Delay: Added Last Call Review Date
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* Updated Name and Block Number

* Updated Ropsten Fork Number

* Updated POA Testnets

* Muir Glacier: Updated lastcall review date and POA Language.

* Difficult Bomb Delay: Added Last Call Review Date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants